[vlc-devel] [RFC 2.2] [PATCH 1/2] vout: avoid picture copy when decoder and output format do not match

[Rémi Denis-Courmont]

On Tue, 18 Jun 2013 23:07:19 +0300, Rémi Denis-Courmont <remi at remlab.net>
wrote:
> When the decoder output and the display video formats are different,
> the picture copy comes for "free" during the conversion from the
> earlier format to the latter one. So do not bother with copying the
> picture before the conversion.
> 
> The straight copy is still required however in the case that the video
> formats are identical but the display pool is inadequate (too few
> pictures, slow memory bus...).

It turns out that this would reopen #3899. I suspect the fix was more of
an ugly work-around; there seems to be a race inside the vout_wrapper when
pictures are invalidated:

commit 2030ca5eb7bb067f268253c358d80ac03a3cd13e
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Wed Oct 20 21:31:33 2010 +0200

    Fixed potential segfault in vout when not using DR (close #3899).
    
    It can happen if the vout display uses the same chroma than the video
but
    doesn't do the resize itself.


-- 
Rémi Denis-Courmont
Sent from my collocated server