[vlc-devel] [PATCH 4/5] vlccore: implement timeout-free poll()

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> 	Hello,
> 
> Unless vlc_cond_(timed)wait() are free of spurious wake-ups, the code is not 
> correct. 

I think, it is free in the context of this patch.

> Also note that VLC code does not cope well with poll() errors other
> than EINTR.
> 

Then, it would be fixed in VLC.

> It is probably a lot simpler to allocate and store the socketpair() in the 
> thread handle and modify OS/2 vlc_cancel() to write to the socket.
> 

Yes, a lot. ^^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.22 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-os2-implement-poll-with-timeout-free-cancellation.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130305/b59a8bac/attachment.ksh>