[vlc-devel] [PATCH] dcp: Creation of LUA script to read DCP

[Pierre Villard]

On 05/03/2013 17:39, Rémi Denis-Courmont wrote:
> Le mardi 5 mars 2013 18:13:02, Pierre Villard a écrit :
>> ---
>>   share/lua/playlist/dcp.lua |  330
>> ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 330
>> insertions(+)
>>   create mode 100644 share/lua/playlist/dcp.lua
> - This script misbehaves when the input is not a local file.
 > What do you mean ? This scripts is not designed to handle streaming 
input.
> - stat() MUST be used to check if a file exists and the file type MUST be
> checked. open()-then-close() is inefficient and prone to deadlock.
 > I wanted to use stat(), but the net module is not usable inside 
/lua/playlist. Should I move the script in another lua folder ? Which one ?
> - Applying the patch generates a warning.
 > How do you get the warning ? I did a 'make check' and I don't get any 
warning.
> - FOR THE UMPTEENTH TIME, a file URI is NOT obtained by prepending file:// to
> the file path.
 > Yes... my mistake. I solved this point.
> - The patch lacks the build system part.
 > To propose a patch is new to me. What do you mean ?


Pierre Villard