[vlc-devel] [PATCH] logger: Add --syslog-ident parameter.

[Rémi Denis-Courmont]

Le mercredi 6 mars 2013 17:02:34, Georgi Chorbadzhiyski a écrit :
> Around 03/06/2013 04:39 PM, Rémi Denis-Courmont scribbled:
> > On Wed,  6 Mar 2013 15:10:22 +0200, Georgi Chorbadzhiyski
> > <gf at unixsol.org>
> > 
> > wrote:
> >> By default VLC uses "vlc" as syslog ident but in case more than one
> >> VLC is logging this may not be enough.
> > 
> > Even if there are more than one concurrent VLC process, each of them has
> > a contemporarily unique process identifier. That is why the LOG_PID flag
> > is set. The issue you describe does not exist.
> 
> I runs tens of VLC instances each transcoding single channel and logs go to
> another machine via syslog. Without ident how can I make the connection
> between the pid and the channel name and each log in different file?

Presumably syslog includes the host identifier as well. Regardless, the case of 
multiple hosts is not mentioned in your patch comments, so nobody could 
possibly guess that was the problem.

> Sure,
> I can make syslog-ng name files based on the pid but that would not be
> very friendly.
> 
> Pretty much every program that offers syslog support allows setting of the
> ident.

Usually, you can customize the facility, sometimes the level. I have yet to 
find a daemon sporting custom identity.

In any case, your patch fails to deal with error and leaks memory.

-- 
Rémi Denis-Courmont
http://www.remlab.net/