[vlc-devel] [PATCH] logger: Add --syslog-ident parameter.

[Rémi Denis-Courmont]

Le mercredi 6 mars 2013 18:17:47, Georgi Chorbadzhiyski a écrit :
> Yes it includes it, but when all processes identify themselves as vlc I
> have no way of knowing which of them is talking when there are 10 VLC's on
> host X. I've seen other daemons that don't offer way of setting
> syslog-ident use argv[0] as the ident /that would also work for me/.

Normally, there is only one VLC with a given PID on a given host...

> >> Sure,
> >> I can make syslog-ng name files based on the pid but that would not be
> >> very friendly.
> >> 
> >> Pretty much every program that offers syslog support allows setting of
> >> the ident.
> > 
> > Usually, you can customize the facility, sometimes the level. I have yet
> > to find a daemon sporting custom identity.
> > In any case, your patch fails to deal with error and leaks memory.
> 
> Little vague, do you mean that I have to free the result of

The string can be NULL *and* needs to be freed.

-- 
Rémi Denis-Courmont
http://www.remlab.net/