[vlc-devel] [PATCH 1/3] Variables declaration

[Rémi Denis-Courmont]

	Hello,

Le mardi 5 mars 2013 04:25:25, Vinicius Steffens Pazzini a écrit :
> diff --git a/.tmp b/.tmp
> new file mode 100755
> index 0000000..dd3f43c
> --- /dev/null
> +++ b/.tmp
> @@ -0,0 +1,2 @@
> +#! /bin/sh
> +exec /vlc -I "" "$@"

WTH is this?

> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index 3835ccb..67e6701 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -1747,6 +1747,10 @@ vlc_module_begin ()
>      add_string( "bookmarks", NULL,
>                   BOOKMARKS_TEXT, BOOKMARKS_LONGTEXT, true )
>          change_safe ()
> +
> +    add_bool( "qt-pause-lose-focus", 0, PAP_TEXT, PAP_LONGTEXT, false )
> +    add_bool( "qt-mute-lose-focus", 0, PAP_TEXT, PAP_LONGTEXT, false )

Qt UI settings belong in the Qt module. Either you implement these in the 
(video output) core code, or you move the settings to the Qt plugin.

> +		change_safe()

Why?

> 
>      set_section( N_( "Default devices") , NULL )

-- 
Rémi Denis-Courmont
http://www.remlab.net/