[vlc-devel] [vlc-commits] Revert "aout: make log message to be debug as there isn' t any real error if no filters needed"

[Ilkka Ollakka]

On Fri, Mar 08, 2013 at 07:52:21PM +0100, Rémi Denis-Courmont wrote:
> Revert "aout: make log message to be debug as there isn't any real error if no filters needed"

> If the user explicitly asks for a filter, it's an error to not be able
> to instatiate it.
> This reverts commit 7b0761c4359d12de0bad78a1d255a55cb89bc562.

Hi,

This msg_Err is triggered for me pretty much with every flac/mp3/vorbis
-file. I don't have scaletempo enabled or any visualisation enabled,
so I don't have any idea why I get error like following:
---

avcodec debug: avcodec codec (Vorbis Audio) started
avcodec debug: Using 384000 bytes output buffer
main debug: using decoder module "avcodec"
main debug: Buffering 0%
main debug: Stream buffering done (454 ms in 1 ms)
main debug: reusing audio output
pulse debug: using stereo channel map
pulse debug: changed buffer metrics: maxlength=4194304, tlength=42336,
prebuf=0, minreq=14112
pulse debug: connected to sink
alsa_output.pci-0000_00_1b.0.analog-stereo
main debug: output 'f32l' 44100 Hz Stereo frame=1 samples/8 bytes
main debug: looking for audio volume module matching "any": 3 candidates
main debug: using audio volume module "float_mixer"
main debug: input 'f32l' 44100 Hz Stereo frame=1 samples/8 bytes
main debug: looking for visualization2 module matching "none": 1
candidates
main debug: no visualization2 modules matched
main error: cannot add user filter none (skipped)
main debug: conversion: 'f32l'->'f32l' 44100 Hz->44100 Hz Stereo->Stereo
main debug: conversion pipeline complete
main debug: looking for audio resampler module matching "any": 3
candidates
main debug: using audio resampler module "samplerate"
main debug: End of audio preroll

---

So basicly it gives me error that it can't add "none" filter. I know the
right thing in this case wasn't hide the error message but still it
gives false errors for me.


> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1267f1526b931609913391b8e9d82c7e9fc1635d
> ---

>  src/audio_output/filters.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/src/audio_output/filters.c b/src/audio_output/filters.c
> index 446f8b6..b46fc2d 100644
> --- a/src/audio_output/filters.c
> +++ b/src/audio_output/filters.c
> @@ -498,7 +498,7 @@ int aout_FiltersNew (audio_output_t *aout,
>                                           name == visual);
>          if (filter == NULL)
>          {
> -            msg_Dbg (aout, "cannot add user filter %s (skipped)", name);
> +            msg_Err (aout, "cannot add user filter %s (skipped)", name);
>              continue;
>          }


> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> http://mailman.videolan.org/listinfo/vlc-commits

-- 
Ilkka Ollakka
Remember, drive defensively! And of course, the best defense is a good offense!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130309/4fdd9dcd/attachment.sig>