[vlc-devel] [PATCH 1/6] Added a new button for playlistshuffle. So far the button invokes a dummy procedure.

[zemanm17 at fel.cvut.cz]

______________________________________________________________
> Od: "Felix Paul Kühne" <fkuehne.videolan at gmail.com>
> Komu: Mailing list for VLC media player developers <vlc-devel at videolan.org>
> Datum: 09.03.2013 11:59
> Předmět: Re: [vlc-devel] [PATCH 1/6] Added a new button for playlistshuffle. So far the button invokes a dummy procedure.
>
>Hello,
>
>First of all, you should squash some of the patches. For our git history, your preliminary implementation is not important, but only your result.

Do you mean doing that by using "git send-email --compose --no-chain-reply-to --to vlc-devel at videolan.org patches" or something else? (It's my first time sending a patch)

>Regarding your implementation: if you dislike the current shuffle function (and there are many reasons to dislike it), please fix it in the playlist core and don't add hacks to the UI module. This way, all interface modules can benefit, like the http, console or Mac modules.

I was under the impression that VLC can't perform a playlist shuffle. Now I see that it's able to do so using the "repeat once" and "random" options together. However the playlist itself is not shuffled by this. 
My aim was to implement "Playlist --> Shuffle" feature of Ticket #5730. So, could you elaborate on what could I improve about the shuffle function?

>Best regards,
>
>Felix
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>http://mailman.videolan.org/listinfo/vlc-devel
>