[vlc-devel] [PATCH] logger: Add --syslog-ident parameter.

Rémi Denis-Courmont remi at remlab.net
Mon Mar 11 11:01:54 CET 2013

On Sun, 10 Mar 2013 17:52:21 +0100, Jean-Baptiste Kempf <jb at videolan.org>
> On 06 Mar, Georgi Chorbadzhiyski wrote :
>> +        const char *ident = syslog_ident ? syslog_ident : "vlc";
> Shouldn't it be EMPTY_STR in the test?

var_InheritString() cannot return "". Unfortunately, the configuration and
variable subsystems do not distinguish empty string and NULL.

Furthermore, I am not a big fan of expansion-UNsafe functional macros.

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list