[vlc-devel] [PATCH 1/4] opengl: Fix the ES 1 vs 2 version check

[Edward Wang]

On 13-03-13 09:26 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Wed, 13 Mar 2013 14:06:34 +0100, Adrien Maglo<magsoft at videolan.org>
> wrote:
>> >Le 13/03/2013 13:45, Jean-Baptiste Kempf a écrit :
>>> >>On 13 Mar, Rémi Denis-Courmont wrote :
>>>> >>>On Tue, 12 Mar 2013 22:59:35 +0100, Felix Paul Kühne
>>>> >>><fkuehne.videolan at gmail.com>  wrote:
>>>>> >>>>OK for me. While in theory, we could switch from ES 1 to ES 2 at run
>>>> >>>time
>>>>> >>>>on iOS, this doesn't make sense, since we support ES2 capable devices
>>>> >>>only.
>>>> >>>
>>>> >>>I still think we should remove ES1 support completely.
>>> >>
>>> >>I agree.
>> >
>> >Removing the support of OpenGL ES 1.x would mean removing the support of
>> >OpenGL 1.x because they share the same code.
>> >There are many desktop configurations, like mine, that are blocked at
>> >OpenGL 1.x.
> And these configurations should use the video overlay instead.
>
> We need to move OpenGL to higher priority than XVideo, to support scaled
> subtitles and high colour depth. But that does not work for/with OpenGL
> (ES) 1.
I don't see think that this has to be a false dichotomy. I think it is 
possible to support both OpenGL ES 1 and 2 at the same time.

Regards,
         Edward Wang