[vlc-devel] [PATCH] access: add rfb/vnc viewonly module.

[Konstantin Pavlov]

On Tue, Mar 12, 2013 at 12:35:27AM +0100, Francois Cartegnie wrote:

Works for me using vncserver 3.3.3.

> +#define CFG_PREFIX "rfb-"

Can it be "vnc-" instead?  I suspect people grepping for possible launch
options to be more familiar with VNC instead of RFB.

> +    if( !rfbInitClient( p_sys->p_client, NULL, NULL ) )
> +    {
> +        msg_Err( p_demux, "rfbInitClient error" );
> +        goto error;
> +    }

Please make the error more understandable to user. "Failed to initialize
client connection" maybe?

-- 
VideoLAN
Konstantin Pavlov
http://www.videolan.org
Mobile: +7 926 165 45 31
Skype: cryothresh
Twitter: @cryothresh