[vlc-devel] [PATCH 2/3] opengl: Split texture uploading to a separate function

[Felix Paul Kühne]

Hello,

On 14.03.2013, at 13:13, Martin Storsjö <martin at martin.st> wrote:

> This allows to reuse the repacking logic for subpictures as well,
> fixing display of subpictures on ES2, where GL_UNPACK_ROW_LENGTH
> isn't available.
> 
> Also avoid mallocing/freeing the temporary buffer for each upload,
> but keep one buffer in the context.

Your new patches perform perfectly for most samples.

However, not for this one:
Format/Info                              : Advanced Video Codec
Format profile                           : Main at L3.1
Format settings, CABAC                   : Yes
Format settings, ReFrames                : 4 frames
Format settings, GOP                     : M=3, N=72
Codec ID                                 : avc1
Codec ID/Info                            : Advanced Video Coding
Bit rate mode                            : Variable
Bit rate                                 : 355 Kbps
Maximum bit rate                         : 7 987 Kbps
Width                                    : 1 152 pixels
Height                                   : 720 pixels
Display aspect ratio                     : 1.600
Frame rate mode                          : Constant
Frame rate                               : 24.000 fps
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Bits/(Pixel*Frame)                       : 0.018
Color primaries                          : BT.601-6 525, BT.1358 525, BT.1700 NTSC, SMPTE 170M
Transfer characteristics                 : BT.601-6 525, BT.601-6 625, BT.1358 525, BT.1358 625, BT.1700 NTSC, SMPTE 170M
Matrix coefficients                      : BT.601-6 525, BT.1358 525, BT.1700 NTSC, SMPTE 170M

http://cl.ly/image/2B1V2i261B2a

Anamorph content is correctly handled now as well as the problematic files I laid out in my previous response. Feel free to ping me, if you need access to the sample in question here.

Additionally, I notice minor artifacts (greenish, bright) when skipping within files or for incomplete frames. In the past, those were covered by a black screen or the previous complete frame (a bit hard to tell from the looks).


Best regards,

Felix