[vlc-devel] [PATCH 1/8] Puzzle filter enhancement

[vianney boyer]

>This split is not correct, I mailed you a better split ;)
>Best regards,
>--
>Jean-Baptiste Kempf



Hi,

I cannot understand what happen with my patches.
Some lines are splitted as you can see in the example below:

original file:
==============
point_t *puzzle_scale_curve_H(int32_t i_width, int32_t i_lines, uint8_t
i_pts_nbr, point_t *ps_pt, int32_t i_shape_size);
point_t *puzzle_H_2_scale_curve_V(int32_t i_width, int32_t i_lines, uint8_t
i_pts_nbr, point_t *ps_pt, int32_t i_shape_size);
point_t *puzzle_curve_H_2_V(uint8_t i_pts_nbr, point_t *ps_pt);
point_t *puzzle_curve_H_2_negative(uint8_t i_pts_nbr, point_t *ps_pt);
point_t *puzzle_curve_V_2_negative(uint8_t i_pts_nbr, point_t *ps_pt);
point_t *puzzle_rand_bezier(uint8_t i_pts_nbr);


patch from git:
===============
+point_t *puzzle_scale_curve_H(int32_t i_width, int32_t i_lines, uint8_t
+i_pts_nbr, point_t *ps_pt, int32_t i_shape_size); point_t
+*puzzle_H_2_scale_curve_V(int32_t i_width, int32_t i_lines, uint8_t
+i_pts_nbr, point_t *ps_pt, int32_t i_shape_size); point_t
+*puzzle_curve_H_2_V(uint8_t i_pts_nbr, point_t *ps_pt); point_t
+*puzzle_curve_H_2_negative(uint8_t i_pts_nbr, point_t *ps_pt); point_t
+*puzzle_curve_V_2_negative(uint8_t i_pts_nbr, point_t *ps_pt); point_t
+*puzzle_rand_bezier(uint8_t i_pts_nbr);


expected patch:
===============
+point_t *puzzle_scale_curve_H(int32_t i_width, int32_t i_lines, uint8_t
i_pts_nbr, point_t *ps_pt, int32_t i_shape_size);
+point_t *puzzle_H_2_scale_curve_V(int32_t i_width, int32_t i_lines,
uint8_t i_pts_nbr, point_t *ps_pt, int32_t i_shape_size);
+point_t *puzzle_curve_H_2_V(uint8_t i_pts_nbr, point_t *ps_pt);
+point_t *puzzle_curve_H_2_negative(uint8_t i_pts_nbr, point_t *ps_pt);
+point_t *puzzle_curve_V_2_negative(uint8_t i_pts_nbr, point_t *ps_pt);
+point_t *puzzle_rand_bezier(uint8_t i_pts_nbr);


I've controlled CR/LF in my file and it is the same than other source code.
I can't find any setting/parameter such as line length when creating a
patch.
I have no warning when creating the patch (and also none during compilation
stage...)
To create the patches I use the command line indicated in VLC wiki:
    rm -Rf patches
    git format-patch -o patches origin
    git send-email --to vlc-devel at videolan.org patches

Do you know the cause of this problem ans how to solve it?

Thanks

Vianney
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130316/90ddd341/attachment.html>