[vlc-devel] [PATCH 2/3] opengl: Split texture uploading to a separate function

[Martin Storsjö]

On Fri, 15 Mar 2013, Felix Paul Kühne wrote:

> Hello,
>
> On 14.03.2013, at 13:13, Martin Storsjö <martin at martin.st> wrote:
>
>> This allows to reuse the repacking logic for subpictures as well,
>> fixing display of subpictures on ES2, where GL_UNPACK_ROW_LENGTH
>> isn't available.
>>
>> Also avoid mallocing/freeing the temporary buffer for each upload,
>> but keep one buffer in the context.
>
> Your new patches perform perfectly for most samples.
>
> However, not for this one:

[snip]

>
> http://cl.ly/image/2B1V2i261B2a
>
> Anamorph content is correctly handled now as well as the problematic files I laid out in my previous response. Feel free to ping me, if you need access to the sample in question here.

These issues should be fixed in the latest revision of the patch I just 
sent.

> Additionally, I notice minor artifacts (greenish, bright) when skipping 
> within files or for incomplete frames. In the past, those were covered 
> by a black screen or the previous complete frame (a bit hard to tell 
> from the looks).

Hmm, on the sample you pointed out, these were present before my patches 
as well. In both of my ES2 test environments, the last 100 pixels or so at 
the right hand side of the screen get updated with green content in one of 
the first few frames of your problematic sample - both before and after my 
patches.

All other issues in that particular sample should be fixed now, or at 
least, things should behave the same as before these patches (except for 
all the issues with ES1 and subpicture overlays that I've fixed).

// Martin