[vlc-devel] [vlc-commits] auhal: implement drain

[David Fuhrmann]

Am 24.03.2013 um 21:56 schrieb "Rémi Denis-Courmont" <remi at remlab.net>:

> Le dimanche 24 mars 2013 22:49:46, David Fuhrmann a écrit :
>> @@ -1287,6 +1299,10 @@ static OSStatus RenderCallbackAnalog(vlc_object_t
>> *p_obj, VLC_UNUSED(inNumberFrames);
>>     }
>> 
>> +    vlc_mutex_lock(&p_sys->lock);
>> +    vlc_cond_signal(&p_sys->cond);
>> +    vlc_mutex_unlock(&p_sys->lock);
> 
> Please tell me, where the hell did you copy this (wrong) code from? Why does 
> everybody developer make the same mistake in turn, inspite of the 
> documentation and so many negative review comments??

I saw this in at least 2 or 3 audio output plugins. Please enlighten me which documentation 
are you referring to. And I am also not aware of negative reviews regarding this, up to now.

Best regards,
David