[vlc-devel] VLC log system regression (was: Re: [PATCH] macosx: fix startup and shutdown procedure)

[David Fuhrmann]

Am 26.03.2013 um 17:59 schrieb "Rémi Denis-Courmont" <remi at remlab.net>:

>> 
>>     return _o_sharedInstance;
>> diff --git a/modules/gui/macosx/intf.m b/modules/gui/macosx/intf.m
>> index c5fced6..398f8dc 100644
>> --- a/modules/gui/macosx/intf.m
>> +++ b/modules/gui/macosx/intf.m
>> @@ -280,7 +280,7 @@ static void Run(intf_thread_t *p_intf)
>>     [[VLCMain sharedInstance] setIntf: p_intf];
>> 
>>     /* subscribe to LibVLCCore's messages */
>> -    vlc_LogSet(p_intf->p_libvlc, MsgCallback, NULL);
>> +    //vlc_LogSet(p_intf->p_libvlc, MsgCallback, NULL);
> 
> This should be moved to wherever the message dialog or MacOS equivalent gets 
> created, and then only after the callback data is initialized.

Hi Remi,

I also noticed this problem recently. You introduced this regression on purpose? Why??
It is just inconsistent, annoying to developers and hardens debugging.

In any case, IMO the current solution for the macosx interface is better, as it logs everything. So if the user experiences some problems, he can simply opens the log and copy the messages. No need for this strange "open log window and restart playback".
Sometimes, the user even may not be able to reproduce the problem so easily, because it does not happen every time or has something to do which interfaces or other persistent modules.

Please also note that deinitializing the log when the window closes also is not implemented in qt interface as of now, as far as I tested.

With best regards,
David