[vlc-devel] [PATCH] Add hotkeys to cycle through previous/next program SIDs.
zoran.turalija at gmail.com
Thu Mar 28 15:25:14 CET 2013
On Thu, Mar 28, 2013 at 10:02:59AM +0100, Zoran Turalija wrote:
> On Thu, Mar 28, 2013 at 08:24:44AM +0100, Rémi Denis-Courmont wrote:
> > On Thu, 28 Mar 2013 05:29:40 +0100, Zoran Turalija
> > <zoran.turalija at gmail.com> wrote:
> > > I'm not capable to reproduce this build failure.
> > Plain 'make' triggers it, though you should always run 'make check' before
> > submitting patches. Also please make sure debug is enabled.
> First of all, thank you for heads up, your patience, time and support.
> When building vlc with aforementioned patch I get:
> [PASS]: ./bootstrap && ./configure && make -j8
> ... and make check passes.
> [FAIL]: ./bootstrap && ./configure --enable-debug && make -j8
> ... and no point in running make check.
> Sure, when using flag '--enable-debug' build fails. I have to figure out
> what is the cause of it. Frankly, I dont know what does
> ./vlc-cache-gen ../modules
> and why modules/plugins.dat generation fails.
> Any hint/idea appreciated.
Well, after debugging, it came to the fact that patch failed because of
this in src/config/keys.c
if (i > 0
&& strcmp (actions[i-1].name, actions[i].name) >= 0)
msg_Err (libvlc, "key-%s and key-%s are not ordered properly",
Therefor, error was in violating imposed sorting order.
Wish I saw this earlier:
static const struct action actions =
/* *MUST* be sorted (ASCII order) */
Anyhow, new patch in attach passes "make check" with --enable-debug...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 6295 bytes
Desc: not available
More information about the vlc-devel