[vlc-devel] [PATCH] Add hotkeys to cycle through previous/next program SIDs.

Zoran Turalija zoran.turalija at gmail.com
Thu Mar 28 20:51:33 CET 2013


On Thu, Mar 28, 2013 at 06:39:35PM +0200, Rémi Denis-Courmont wrote:
> Le jeudi 28 mars 2013 16:25:14, Zoran Turalija a écrit :
> > Wish I saw this earlier:
> 
> You should always enable debug when you modify source code...

True.
 
> > Anyhow, new patch in attach passes "make check" with --enable-debug...
> 
> Patch merged.
> 
> Note that I don't really like to change the name of hotkeys as it breaks 
> backward compatibility. Luckily in this case it only affects older development 
> versions.

I also support your stance, though for this new functionality older hotkey name
could have been preserved at the expence of slightly less readable and/or
understandable code, while keeping full backward compatibility.

Thanks.

-- 
Kind regards,
Zoran Turalija



More information about the vlc-devel mailing list