[vlc-devel] [PATCH] Revert "Switch smbclient detection to pkg-config"

[Zoran Turalija]

On Fri, Mar 29, 2013 at 07:28:12PM +0200, Rémi Denis-Courmont wrote:
> Le vendredi 29 mars 2013 17:25:24, Zoran Turalija a écrit :
> > This reverts commit 783ebff1298ce44abacb1e394333b892ac401d18.
> > 
> > Ubuntu (hardy - raring) and Debian (all except experimental/rc-buggy)
> > do not have smbclient.pc file in their libsmbclient-dev.
> 
> As far as I can tell, smbclient.pc has been there for over 5 years.
> 
> If there is a bug in Debian or Ubuntu, fix it or work around it in Debian or 
> Ubuntu.

Sure, I said that already on IRC. At least, part about whose bug it is.
But, if you just send message - "fix upstream", it wont hide the fact that
783ebff129 commit just broke on logic "don't break something that wasnt broken
before."

Maybe that is not the motto of this open source project?

And it is user unfriendly. For all current Ubuntu/Debian users (excluding Debian
experimental/rc-buggy users). And it is clear that commit improved "a lot" how
configure detects smbclient; just as clear as it brakes detection for many current
users.

It is a normal thing in open source project to revert commit that broke previous
working state. But, ones with power to commit will decide eventually.

And thanks for sharing your opinion.

-- 
Kind regards,
Zoran Turalija