[vlc-devel] [PATCH] equalizer: Optimize calculations of alpha, beta, and gamma constants

Rémi Denis-Courmont remi at remlab.net
Sat Mar 30 11:14:23 CET 2013


Le vendredi 29 mars 2013 00:58:47, Ronald Wright a écrit :
> It is easy to see that the computation of the alpha constant is slightly
> inefficient, as the root value can be close to 1 for the lower frequencies,
> which would result in significant roundoff error if this value is
> subtracted from 1.  In this patch, the computation of the alpha, beta, and
> gamma constants has been simplified and refactored.

TBH I don't have a pencil and a paper to double check the maths right now. 
Just wondering though, shouldn't sinf(), cosf() and .5f be used instead? (That 
could be a separate patch anyway.)

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list