[vlc-devel] [PATCH] contrib: ffmpeg: add flags for armv6

[Martin Storsjö]

On Fri, 10 May 2013, Rafaël Carré wrote:

> ---
> contrib/bootstrap            | 1 +
> contrib/src/ffmpeg/rules.mak | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/contrib/bootstrap b/contrib/bootstrap
> index a455992..bcd0bb8 100755
> --- a/contrib/bootstrap
> +++ b/contrib/bootstrap
> @@ -198,6 +198,7 @@ check_android_sdk()
> 	add_make "ANDROID_ABI := ${ANDROID_ABI}"
> 	[ ${ANDROID_ABI} = "armeabi-v7a" ] && add_make_enabled "HAVE_NEON"
> 	[ ${ANDROID_ABI} = "armeabi-v7a" ] && add_make_enabled "HAVE_ARMV7A"
> +	[ ${ANDROID_ABI} = "armeabi" ] && add_make_enabled "HAVE_ARMV6"
> }

Umm, armeabi is armv5, not 6, or are you intentionally ignoring such 
devices? OTOH, the patch itself doesn't add anything armv6-specific except 
for tuning for such a cpu, but it would be an easy mistake to make, if 
someone were to add e.g. --arch=armv6 in the HAVE_ARMV6 block below.

Then again, if it's intentionaly to ignore armv5 devices (are there any at 
all? - the HTC G1 was an armv6), that's a different thing but should 
clearly be marked so.

// Martin