[vlc-devel] [PATCH] build against libdvbpsi >= 1.0.0 (or an older version)

[Rafaël Carré]

Hi Jean-Paul,

Le 13/05/2013 14:25, Jean-Paul Saman a écrit :

> +#if (DVBPSI_VERSION_INT >= DVBPSI_VERSION_WANTED(1,0,0))
> +# define dvbpsi_handle dvbpsi_t*
> +# define dvbpsi_PushPacket(handle,data) dvbpsi_packet_push((handle),(data))
> +# define dvbpsi_DeleteSDT(table)        dvbpsi_sdt_delete((table))

Unneeded parenthesis?

> +# define dvbpsi_DeleteTOT(table)        dvbpsi_tot_delete((table))
> +# define dvbpsi_DeleteEIT(table)        dvbpsi_eit_delete((table))
> +# define dvbpsi_DeletePMT(table)        dvbpsi_pmt_delete((table))
> +# define dvbpsi_DeletePAT(table)        dvbpsi_pat_delete((table))
> +
> +static void dvbpsi_messages(dvbpsi_t *p_dvbpsi, const dvbpsi_msg_level_t level, const char* msg)
> +{
> +    vlc_object_t *obj = (vlc_object_t *)p_dvbpsi->p_sys;
> +
> +    /* See dvbinfo.h for the definition of these log levels.*/
> +    switch(level)
> +    {
> +        case DVBPSI_MSG_ERROR: msg_Err( obj, "%s", msg ); break;
> +        case DVBPSI_MSG_WARN:  msg_Warn( obj, "%s", msg ); break;
> +        case DVBPSI_MSG_DEBUG: msg_Dbg( obj, "%s", msg ); break;
> +        default: msg_Info( obj, "%s", msg ); break;
> +    }
> +}
> +#endif

Why not put that in some header ?