[vlc-devel] [PATCH 1/2] Adds Intel QuickSync Video Encoder

[Rafaël Carré]

Le 17/05/2013 03:48, Julien 'Lta' BALLET a écrit :
> Hi,
> 
> Thank you again funman for reviewing the patch.
> I still have a question.
> 
> 
> On Thu, May 16, 2013 at 4:50 PM, Rafaël Carré <funman at videolan.org> wrote:
> 
>>> +// Frame pool for QuickSync video encoder with Intel Media SDK's format frames.
>>> +typedef struct qsv_frame_pool_t
>>> +{
>>> +    mfxFrameInfo          fmt;            // IntelMediaSDK format info.
>>> +    mfxFrameSurface1      *frames;        // An allocated array of 'size' frames.
>>> +    unsigned int          size;           // The number of frame in the pool.
>>> +} qsv_frame_pool_t;
>>
>> Still unnecessary padding.
> 
> Are you talking of the padding at the end of the structure or the
> possible padding between fmt and frames ?

Padding between fmt and frames, the biggest members (pointers) should
appear first in the struct