[vlc-devel] [PATCH] skins2: add OS/2 support
brezhoneg1
brezhoneg1 at yahoo.fr
Fri May 17 18:05:35 CEST 2013
resent because a first message seems to have vanished into thin air !
Le 17/05/2013 10:39, KO Myung-Hun a écrit :
> ---
> configure.ac | 3 +
> extras/package/os2/configure.sh | 2 +-
> modules/gui/skins2/Modules.am | 21 ++
> modules/gui/skins2/os2/os2_dragdrop.cpp | 40 +++
> modules/gui/skins2/os2/os2_dragdrop.hpp | 50 ++++
> modules/gui/skins2/os2/os2_factory.cpp | 452 ++++++++++++++++++++++++++++
> modules/gui/skins2/os2/os2_factory.hpp | 152 ++++++++++
> modules/gui/skins2/os2/os2_graphics.cpp | 453 +++++++++++++++++++++++++++++
> modules/gui/skins2/os2/os2_graphics.hpp | 140 +++++++++
> modules/gui/skins2/os2/os2_loop.cpp | 295 +++++++++++++++++++
> modules/gui/skins2/os2/os2_loop.hpp | 68 +++++
> modules/gui/skins2/os2/os2_popup.cpp | 129 ++++++++
> modules/gui/skins2/os2/os2_popup.hpp | 69 +++++
> modules/gui/skins2/os2/os2_timer.cpp | 102 +++++++
> modules/gui/skins2/os2/os2_timer.hpp | 68 +++++
> modules/gui/skins2/os2/os2_tooltip.cpp | 92 ++++++
> modules/gui/skins2/os2/os2_tooltip.hpp | 54 ++++
> modules/gui/skins2/os2/os2_window.cpp | 237 +++++++++++++++
> modules/gui/skins2/os2/os2_window.hpp | 90 ++++++
> modules/gui/skins2/parser/builder.cpp | 2 +-
> modules/gui/skins2/src/os_factory.cpp | 4 +
> modules/gui/skins2/src/skin_main.cpp | 2 +-
> modules/gui/skins2/src/vout_manager.hpp | 2 +-
> modules/gui/skins2/src/window_manager.cpp | 6 +-
> diff --git a/modules/gui/skins2/src/window_manager.cpp b/modules/gui/skins2/src/window_manager.cpp
> index 780b765..093e6d3 100644
> --- a/modules/gui/skins2/src/window_manager.cpp
> +++ b/modules/gui/skins2/src/window_manager.cpp
> @@ -275,13 +275,13 @@ void WindowManager::resize( GenericLayout &rLayout,
> int xNewOffset = newWidth - rLayout.getWidth();
> int yNewOffset = newHeight - rLayout.getHeight();
>
> - // Do the actual resizing
> - rLayout.resize( newWidth, newHeight );
> -
> // Resize the window
> TopWindow *pWindow = rLayout.getWindow();
> pWindow->resize( newWidth, newHeight );
>
> + // Do the actual resizing
> + rLayout.resize( newWidth, newHeight );
> +
> // refresh content
> rLayout.refreshAll();
Any technical reasons why you moved layout resizing after window
resizing ? or is it just cosmetics ? which is okay anyway.
This seems good to me, doesn't bring regression on Linux and I guess it
also compiles and runs fine on OS/2 ....
I am not familiar with committing somebody else's patch. I leave it to
sbdy who knows how to do it
Erwan
More information about the vlc-devel
mailing list