[vlc-devel] [PATCH 1/4] Fixed contrib compiler selection on MacOS X

[Maxim Bublis]

Could i rework this patch to add inner ifdef for OSX_VERSION=10.9 to fix
build on MacOS X 10.9?
All contrib libraries on 10.9 built with clang without any problem.


On Thu, Nov 7, 2013 at 3:44 PM, Felix Paul Kühne <fkuehne at videolan.org>wrote:

> Dear Maxim,
>
> On 07.11.2013, at 11:47, Maxim Bublis <b at codemonkey.ru> wrote:
>
> > ---
> > contrib/src/main.mak | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> > index 4e568ec..a40cba2 100644
> > --- a/contrib/src/main.mak
> > +++ b/contrib/src/main.mak
> > @@ -97,8 +97,8 @@ endif
> >
> > ifdef HAVE_MACOSX
> > MIN_OSX_VERSION=10.6
> > -CC=xcrun llvm-gcc-4.2
> > -CXX=xcrun llvm-g++-4.2
> > +CC=xcrun clang
> > +CXX=xcrun clang++
>
> Technically, this patch is correct. However, we can't merge it as is as
> there are still some contrib libraries left which simply don't compile with
> clang, notably GnuTLS and some other weirdos. We need patches to compile
> those with clang first prior to switching from llvm-gcc to clang.
> My "official" 2.1.0 build was created on 10.7 where llvm-gcc-4.2 still
> exists as part of Xcode 4.6.2 (it was only recently removed in Xcode 5.0).
>
> Best regards,
>
> Felix
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Maxim Bublis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131107/d0b6de1f/attachment.html>