[vlc-devel] [PATCH] Sort avcodec mapping table by AVCodecID enum

[Rafaël Carré]

Le 09/11/2013 20:07, Daniel Verkamp a écrit :
> On Sat, Nov 9, 2013 at 3:23 AM, Rafaël Carré <funman at videolan.org> wrote:
>>
>> Le 09/11/2013 04:56, Daniel Verkamp a écrit :
>>> This makes it much easier to tell which codec ID mappings are missing
>>> (or intentionally skipped).
>>>
>>> Comments have been added for each codec ID that is currently missing.
>>>
>>> Ordering between codecs with the same avcodec ID or VLC fourcc has been
>>> preserved.
>>>
>>> No functional change.
>>
>> Thanks, applied that one too!
> 
> 
> Thanks.
> 
>>> +    /* ffmpeg only: AV_CODEC_ID_MICRODVD */
>>> +    /* ffmpeg only: AV_CODEC_ID_EIA_608 */
>>> +    /* ffmpeg only: AV_CODEC_ID_JACOSUB */
>>> +    /* ffmpeg only: AV_CODEC_ID_SAMI */
>>> +    /* ffmpeg only: AV_CODEC_ID_REALTEXT */
>>> +    /* ffmpeg only: AV_CODEC_ID_SUBVIEWER1 */
>>> +    /* ffmpeg only: AV_CODEC_ID_SUBVIEWER */
>>> +    /* ffmpeg only: AV_CODEC_ID_SUBRIP */
>>> +    /* ffmpeg only: AV_CODEC_ID_WEBVTT */
>>> +    /* ffmpeg only: AV_CODEC_ID_MPL2 */
>>> +    /* ffmpeg only: AV_CODEC_ID_VPLAYER */
>>> +    /* ffmpeg only: AV_CODEC_ID_PJS */
>>> +    /* ffmpeg only: AV_CODEC_ID_ASS */
>>
>> ... lol
> 
> Not taking sides, just keeping track...

No problem with that I think this is great to keep track of the differences.

> I am digging up samples and testing the missing codecs.
> Should I send the added codec mappings as one big patch, or would it
> be preferred to split them up by codec?
> 
> Thanks,

Ideally this should be one commit per codec with a link to a known
sample but maybe that will require uploading the samples first on
streams.videolan.org