[vlc-devel] [vlc-commits] gnutls: fix build by initalizing LDFLAGS

David Fuhrmann david.fuhrmann at gmail.com
Tue Nov 12 19:54:30 CET 2013

Am 12.11.2013 um 19:22 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> Le lundi 11 novembre 2013 08:33:52 David Fuhrmann a écrit :
>> vlc/vlc-2.1 | branch: master | David Fuhrmann
>> <david.fuhrmann at googlemail.com> | Mon Nov 11 08:32:23 2013 +0100|
>> [4b4f0ddf289bb3833b1bb0bf39138aa7849d8f2b] | committer: David Fuhrmann
>> gnutls: fix build by initalizing LDFLAGS
> Err, what is the point in assigning a Makefile variable to its *default* value?

To avoid the same build error if other flags are conditionally appended to the variable, as the variable might not be initialized at all in some cases.

What would be your preferred way? Just conditionally overwrite libgnutls_plugin_la_LDFLAGS by using = instead of +=, and hope that nobody adds important values before? Does not look like a good solution, either.

Best regards,

More information about the vlc-devel mailing list