[vlc-devel] [PATCH] Implement basic Opus support in MKV

[Rafaël Carré]

Le 14/11/2013 17:35, Denis Charmet a écrit :
> Le jeudi 14 novembre 2013 à 05:22:30, Rafaël Carré a écrit :
>> if (i_seek_preroll < tracks[i_track]->i_seek_preroll)
>>     i_seek_preroll = tracks[i_track]->i_seek_preroll;
>>
>> is simpler to read than ternary
> And I prefer ternary so I'll use __MAX() so it's even more readable.
>>> +        if( xiph_PackHeaders( (int *)&p_tk->fmt.i_extra,
>>> +                              (void **) &p_tk->fmt.p_extra,
>>
>> Why do you need a cast to (int*) and (void**) ?
>>
> Because C++.

es_format_t->i_extra is an int and es_format_t->p_extra is a void * already

> Regards,
>