[vlc-devel] [PATCH v2 1/4] Fixed contrib compiler selection on MacOS X 10.9

Rafaël Carré funman at videolan.org
Fri Nov 15 14:45:14 CET 2013


Le 15/11/2013 10:45, Maxim Bublis a écrit :
> There is no way to write greater-than conditions in Makefile except usage
> of shell commands.
> I could propose usage of something like checking XCode version, which is
> better then checking OS X version as absence of llvm-gcc-4.2 depends on
> XCode version, not OS X one:
> 
> if [ $(xcodebuild -version | head -n 1 | sed 's/[^0-9]//g') -ge 500 ] ;
> then echo "Ok"; fi
> 
> llvm-gcc-4.2 is absent starting from XCode 5.0.0

Can you rather check if llvm-gcc-4.2 exists or if xcrun llvm-gcc-4.2
returns 0?

P.S. please avoid top-posting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

> May this patch be more appropriate?
> 
> 
> On Fri, Nov 15, 2013 at 12:58 PM, Rémi Denis-Courmont <remi at remlab.net>wrote:
> 
>> On Fri, 15 Nov 2013 12:28:26 +0400, Maxim Bublis <b at codemonkey.ru> wrote:
>>> Patch has been updated to use clang only on MacOS X 10.9.
>>
>> So what will happen in later versions?



More information about the vlc-devel mailing list