[vlc-devel] [PATCH v4 1/4] Fixed contrib compiler on MacOS X 10.9

[Felix Paul Kühne]

On 18.11.2013, at 22:32, Rafaël Carré <funman at videolan.org> wrote:

> Le 18/11/2013 21:36, Maxim Bublis a écrit :
>> ---
>> contrib/src/main.mak | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 4e568ec..1ab1eaf 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -97,8 +97,8 @@ endif
>> 
>> ifdef HAVE_MACOSX
>> MIN_OSX_VERSION=10.6
>> -CC=xcrun llvm-gcc-4.2
>> -CXX=xcrun llvm-g++-4.2
>> +CC=llvm-gcc
>> +CXX=llvm-g++
>> AR=xcrun ar
>> LD=xcrun ld
>> STRIP=xcrun strip
> 
> LGTM.

Almost. You should still add the "xcrun" prefix so we can switch between multiple installed Xcode versions at compilation time without editing the script.

Cheers,

Felix