[vlc-devel] [PATCH] Fixed unused variable and parameter warnings.

[Rémi Denis-Courmont]

On Wed, 20 Nov 2013 13:47:23 +0400, Maxim Bublis <b at codemonkey.ru> wrote:
> You are right, i was building without --enable-debug configure flag.
> Enabling that flag surely hides these warnings, but in my opinion (i
could
> be wrong) unused variable warnings should be fixed independent of
> --enable-debug flag.

There is no nice way to avoid those warnings when the variable is used in
an assertion. ifdefs are not good, and gratuitious void casts just hides
potential problems when revectoring.

Also, even excluding assertion cases, some of your changes are hiding real
unfixed bugs in my opinion.

-- 
Rémi Denis-Courmont
Sent from my collocated server