[vlc-devel] [PATCH] network: export SO_RCVBUF & SR_SNDBUF as config options

[Ilkka Ollakka]

On Thu, Aug 15, 2013 at 08:37:33PM +0800, Tzu-Jung Lee wrote:
> Hi Remi,

Hi all,

Joining this thread even if I'm littlebit late to comment.


> On Tue, Aug 13, 2013 at 2:44 AM, Tzu-Jung Lee <roylee17 at gmail.com> wrote:

> > I believe it's case by case :-). And that's why I think it make sense
> > to export them
> > as configs.

> >> The default for VLC (at least on Linux) should simply be to leave it alone,
> >> though, as Linux has socket buffer size auto-tuning these days.

> > Leave it alone for Linux probably will be fine since we can still manipulate the
> > system-wise default values if we have to.

I agree that atleast in Linux we should just remove the calls to change
recvbuf and sendbuf. Haven't tested in Windows how well Windows can tune
those itself to be proper.

Atleast for my testing HD udp/ts multicat stream drop packets here and
there with default code and removing recvbuf calls all together and use
os level stuff to tune buffers fix this.

-- 
Ilkka Ollakka
"I never let my schooling get in the way of my education."
		-- Mark Twain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131120/8ed2fa42/attachment.sig>