[vlc-devel] [PATCH] core: do not overwrite visible size

[XilasZ]

> It looks like the call to video_format_ScaleCropAr should be removed here.
>

I don't know if it should be removed, i don't understand what it is trying
to do.


With all the changes mentioned above, it looks like I don't have green
> lines anymore on thumbnails and videos. I will do more extensive
> testing and send a patch next week.
> Also, I couldn't reproduce the issue reported by XilasZ on 720p videos.
>

Here's what i changed to get some details (Vittorio's patch + some logs in
swscale) : http://xilasz.free.fr/Android/redesign/swscale-debug.patch
With this, i got this output :

1280x720 video (thumbnailer/vmem asks for 720x405) :

swscale filter: 1280x738 (1280x720) chroma: I420 -> 720x405 (720x395)
chroma: RGBA extend by 1
swscale filter: 1280x738 (1280x720) chroma: I420 -> 720x405 (720x395)
chroma: RGBA with scaling using Bicubic (good quality)
swscale filter: i_height=738
swscale filter: src 1280x772 (1280x738)
swscale filter: dst 720x405 (720x405)

48x48 video (thumbnailer/vmem asks for 405x405) :

swscale filter: 48x66 (48x48) chroma: I420 -> 405x405 (405x294) chroma:
RGBA extend by 1
swscale filter: 48x66 (48x48) chroma: I420 -> 405x405 (405x294) chroma:
RGBA with scaling using Bicubic (good quality)
swscale filter: i_height=66
swscale filter: src 64x100 (48x66)
swscale filter: dst 405x405 (405x405)

we can see that swscale is initialized with correct size/visible_size on
input, and a strange visible_size on output, caused by
video_format_ScaleCropAr.
But what's bothering me, is the picture_t swscale receives in
Filter(filter_t*, picture_t*) :
swscale filter: src 1280x772 (1280x738)
swscale filter: src 64x100 (48x66)

where are these coming from ?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131124/f34b1c3e/attachment.html>