[vlc-devel] [PATCH] vout: set visible resolution of input/output video formats in SpuRenderCreateAndLoadScale().

Rémi Denis-Courmont remi at remlab.net
Mon Nov 25 15:35:10 CET 2013


On Mon, 25 Nov 2013 15:05:07 +0100, Felix Abecassis
<felix.abecassis at gmail.com> wrote:
> ---
>  src/video_output/vout_subpictures.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

It looks OK, but the log copmments should specify what this helps with,
whatever that is, I think.

> 
> diff --git a/src/video_output/vout_subpictures.c
> b/src/video_output/vout_subpictures.c
> index 416a04c..9a16590 100644
> --- a/src/video_output/vout_subpictures.c
> +++ b/src/video_output/vout_subpictures.c
> @@ -238,12 +238,16 @@ static filter_t
> *SpuRenderCreateAndLoadScale(vlc_object_t *object,
>      es_format_Init(&scale->fmt_in, VIDEO_ES, 0);
>      scale->fmt_in.video.i_chroma = src_chroma;
>      scale->fmt_in.video.i_width =
> -    scale->fmt_in.video.i_height = 32;
> +    scale->fmt_in.video.i_visible_width =
> +    scale->fmt_in.video.i_height =
> +    scale->fmt_in.video.i_visible_height = 32;
>  
>      es_format_Init(&scale->fmt_out, VIDEO_ES, 0);
>      scale->fmt_out.video.i_chroma = dst_chroma;
>      scale->fmt_out.video.i_width =
> -    scale->fmt_out.video.i_height = require_resize ? 16 : 32;
> +    scale->fmt_out.video.i_visible_width =
> +    scale->fmt_out.video.i_height =
> +    scale->fmt_out.video.i_visible_height = require_resize ? 16 : 32;
>  
>      scale->pf_video_buffer_new = spu_new_video_buffer;
>      scale->pf_video_buffer_del = spu_del_video_buffer;

-- 
Rémi Denis-Courmont
Sent from my collocated server



More information about the vlc-devel mailing list