[vlc-devel] [PATCHv6] dcp: Creation of access-demux module for DCP

Nicolas Bertrand nicoinattendu at gmail.com
Mon Nov 25 22:24:38 CET 2013

Le 25/11/2013 16:23, Denis Charmet a écrit :
>> +            fillVideoFmt( &video_format.video, p_PicDesc->StoredWidth, p_PicDesc->StoredHeight, p_PicDesc->EditRate.Numerator, p_PicDesc->EditRate.Denominator );
>> >+
>> >+            p_sys->p_PicDesc = p_PicDesc;
>> >+            p_sys->frame_rate_num = p_PicDesc->EditRate.Numerator;
>> >+            p_sys->frame_rate_denom = p_PicDesc->EditRate.Denominator;
>> >+            p_sys->frames_total = p_PicDesc->ContainerDuration;
> This feels quite redundant if you already hold them in p_sys->p_PicDesc.
> Of course one could argue that you avoid one dereference but still. Is
> it that critical? Or is it just because there could be a p_VideoDesc
> instead. In that case, is it really useful to keep p_PicDesc in the
I'm not sure to understand the remark we cannot have p_PicDesc and 
p_VideoDesc at the same time. Video is JPEG2000 (PicDesx) or MPEG2 

More information about the vlc-devel mailing list