[vlc-devel] [PATCH 3/5] core: do not overwrite visible size

[Vittorio Giovara]

On Tuesday, November 26, 2013, Rémi Denis-Courmont wrote:

>     Hello,
>
> On Tue, 26 Nov 2013 14:21:30 +0100, Felix Abecassis
> <felix.abecassis at gmail.com <javascript:;>> wrote:
> > From: Vittorio Giovara <vittorio.giovara at gmail.com <javascript:;>>
> >
> > ---
> >  src/video_output/display.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/src/video_output/display.c b/src/video_output/display.c
> > index 33734f1..2cc0e06 100644
> > --- a/src/video_output/display.c
> > +++ b/src/video_output/display.c
> > @@ -1292,14 +1292,9 @@ static vout_display_t *DisplayNew(vout_thread_t
> > *vout,
> >      }
> >      owner.sys = osys;
> >
> > -    /* */
> > +    /* keep a reference to the source before display */
> >      video_format_t source = *source_org;
> >
> > -    source.i_x_offset = 0;
> > -    source.i_y_offset = 0;
> > -    source.i_visible_width  = source.i_width;
> > -    source.i_visible_height = source.i_height;
> > -
> >      vout_display_t *p_display = vout_display_New(VLC_OBJECT(vout),
> >                                                   module, !is_wrapper,
> >                                                   &source, cfg, &owner);
>
> There is no point left copying the structure if you do not modify it.
>
>
Right, however source after this point is widely used and didn't want to
bring in unrelated changes.

I'll post a separate patch soon.

Vittorio


> --
> Rémi Denis-Courmont
> Sent from my collocated server
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131126/6abff0e1/attachment.html>