[vlc-devel] [PATCH] ogg: fix invalid PCR value on 32-bit systems

Tristan Matthews le.businessman at gmail.com
Wed Nov 27 07:16:52 CET 2013


On Wed, Nov 27, 2013 at 1:03 AM, Tristan Matthews
<le.businessman at gmail.com> wrote:
> Fixes beginning of playback of Opus files, where the first few seconds were
> being dropped on 32-bit systems. Refs #9828.
> ---
>  modules/demux/ogg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/modules/demux/ogg.c b/modules/demux/ogg.c
> index a901c69..38be23f 100644
> --- a/modules/demux/ogg.c
> +++ b/modules/demux/ogg.c
> @@ -273,7 +273,7 @@ static int Demux( demux_t * p_demux )
>              Oggseek_ProbeEnd( p_demux );
>
>          msg_Dbg( p_demux, "beginning of a group of logical streams" );
> -        es_out_Control( p_demux->out, ES_OUT_SET_PCR, VLC_TS_0 );
> +        es_out_Control( p_demux->out, ES_OUT_SET_PCR, (int64_t) VLC_TS_0 );
>      }
>
>      /*
> @@ -353,7 +353,7 @@ static int Demux( demux_t * p_demux )
>                  p_stream->i_pcr = VLC_TS_0;
>                  p_stream->i_interpolated_pcr = VLC_TS_0;
>                  p_stream->i_previous_granulepos = -1;
> -                es_out_Control( p_demux->out, ES_OUT_SET_PCR, VLC_TS_0);
> +                es_out_Control( p_demux->out, ES_OUT_SET_PCR, (int64_t) VLC_TS_0 );
>              }
>
>              /* Does fail if serialno differs */
> --
> 1.8.1.2
>

Note that this patch just addresses the issue of the first few seconds
being skipped when starting the stream (which was not present on
64-bit). It does not fix the issue of the first few seconds of the
file being skipped when seeking back to the start.
I mention it here because #9828 seems to be referring to both of these problems.

Best,
Tristan

-- 
Tristan Matthews
web: http://tristanswork.blogspot.com



More information about the vlc-devel mailing list