[vlc-devel] [PATCH V7] dcp: Creation of access-demux module for DCP

[Jean-Baptiste Kempf]

On 27 Nov, Nicolas Bertrand wrote :
> + * Authors:
> + *          Claire Etienne
> + *          Aurélie Sbinné
> + *          Pierre Villard <pierre dot villard dot fr at gmail dot com>
> + *          Samuel Kerjose
> + *          Julien Puyobro
> + *          Simona-Marinela Prodea <simona dot marinela dot prodea at gmail dot com>
> + *          Nicolas Bertrand <nico at isf.cc>

Authors order should be changed. And I think I'm missing :D

> +#ifdef HAVE_CONFIG_H
> +#include "config.h"
> +#endif

Nitpick, indent the second line:
# include

> +    /* Parsing XML files to get audio and video files */
> +    msg_Dbg( p_demux, "parsing XML files..." );
> +    if( ( retval = parseXML( p_demux ) ) )
> +        goto error;
> +
> +    msg_Dbg(p_demux, "parsing XML files done");
> +
> +    msg_Dbg( p_demux, "path = %s", p_sys->p_dcp->path.c_str() );
> +    msg_Dbg( p_demux, "video = %s", p_sys->p_dcp->videofile.c_str() );
> +    msg_Dbg( p_demux, "audio = %s", p_sys->p_dcp->audiofile.c_str() );

A bit too much  debug here.
Use #ifndef NDEBUG for those.

The rest looks good. 

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device