[vlc-devel] [PATCH 2/2] Support Media Enhancement Data - MED module

[Rémi Denis-Courmont]

	Hello,

Le lundi 7 octobre 2013 16:14:37 Roiy Shpaner a écrit :
> And the second patch - the new module.
> 
> This was based off of the subtitle.c module and subtitles.c so it still
> contains small parts that are unrelated.

The job of a demuxer is to drive the elementary stream output. There are 
basically three ways a demuxer can achieve that:
1) Use es_out_*() directly. That is by far the most common.
2) Spawn a child demuxer and delegate the job to it somehow.
3) Or create input subitems. That would be a playlist parser.
I fail to see how this code, as it currently stands, fits the demux 
abstraction.

Regardless, a demux cannot write its own input. Depending on the operating/file 
system, this will either simply fail or confuse the underlying file access 
object. By comparison, note that reading and writing meta data are performed 
by distinct objects.

Finally, a demux cannot control its own input. In fact, there may be more than 
one demuxes as children of a single input, or they may be no input at all. 
Some demuxers do access their parent input, but only to create input subitems 
(playlist parsing) or to catch mouse events (menu navigation), for lack of 
better dedicated functions.

Regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net/