[vlc-devel] [PATCH] Audio core: avoid FPE in aout_ChannelReorder

[Rémi Denis-Courmont]

On Thu, 10 Oct 2013 14:20:36 +0200, Jean-Baptiste Kempf <jb at videolan.org>
wrote:
> On 10 Oct, Rémi Denis-Courmont wrote :
>> On Thu, 10 Oct 2013 10:54:05 +0200, Jean-Baptiste Kempf
<jb at videolan.org>
>> wrote:
>> > aout_BitsPerSample can return 0 in some valid situations
>> 
>> BitsPerSample can be 0 if the format is non-linear,
> 
> or if the codec is not part of the defined list.

Well, there may be an issue if the sample size is not a multiple of 8
bits. But your patch does not fix that case anyway.

>> but reodering channels is then NOT valid. It does not even make sense.
> 
> It is the case with the 'araw' codec in wav. But maybe the wav demuxer
> should be fixed then.

Thing is, your patch does not fix that case either. It avoids the SIGFPE
but the audio channels will be misordered regardless.

> And then it should assert if it is NOT valid.

Absolutely.

-- 
Rémi Denis-Courmont
Sent from my collocated server