[vlc-devel] [PATCH] core: do not overwrite visible size

[Rafaël Carré]

Hi,

Le 15/10/2013 10:47, Vittorio Giovara a écrit :
> ---
> This patch should address a few preview rendering on Android, but I could not test this on a real device.

This doesn't seem to have any impact (right or wrong) as is.

> In general the visible_* size should not be overwritten and this
modification does not impact normal
> use according to the tests I did.
> Some renderers still show some green line, I'll have a look later on.

I would prefer to wait for the following patches before applying this
one to be sure we understand well what's going on.

So, I'm not committing this patch alone, but keeping it under the hand.

> Cheers,
>         Vittorio
> 
>  src/video_output/display.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/src/video_output/display.c b/src/video_output/display.c
> index 33734f1..2cc0e06 100644
> --- a/src/video_output/display.c
> +++ b/src/video_output/display.c
> @@ -1292,14 +1292,9 @@ static vout_display_t *DisplayNew(vout_thread_t *vout,
>      }
>      owner.sys = osys;
>  
> -    /* */
> +    /* keep a reference to the source before display */
>      video_format_t source = *source_org;
>  
> -    source.i_x_offset = 0;
> -    source.i_y_offset = 0;
> -    source.i_visible_width  = source.i_width;
> -    source.i_visible_height = source.i_height;
> -
>      vout_display_t *p_display = vout_display_New(VLC_OBJECT(vout),
>                                                   module, !is_wrapper,
>                                                   &source, cfg, &owner);
>