[vlc-devel] [PATCH] Revert "avi: Tidy the palette handling bit."

Rafaël Carré funman at videolan.org
Tue Oct 15 17:34:58 CEST 2013


Le 15/10/2013 17:27, Denis Charmet a écrit :
> Hi,
> 
> Le mardi 15 octobre 2013 à 05:18:06, Rafaël Carré a écrit :
>> +                    __MAX( p_vids->p_bih->biSize - sizeof( VLC_BITMAPINFOHEADER ),
>> +                           p_vids->i_chunk_size - sizeof(VLC_BITMAPINFOHEADER) );
> not __MIN?

See 7f99f183c055dbb657a896adb568687b6264df44 from the same author.

https://trac.videolan.org/vlc/ticket/5952 has been reopened.

Should we revert the whole of his 2 commits ?

>> +                if( fmt.i_extra > 0 )
>> +                {
>> +                    fmt.p_extra = malloc( fmt.i_extra );
>> +                    if( !fmt.p_extra ) goto error;
>> +                    memcpy( fmt.p_extra, &p_vids->p_bih[1], fmt.i_extra );
>> +                }
>>  
> 
> Regards,
> 




More information about the vlc-devel mailing list