[vlc-devel] [PATCH] Revert "avi: Tidy the palette handling bit."

Denis Charmet typx at dinauz.org
Tue Oct 15 18:17:08 CEST 2013


Le mardi 15 octobre 2013 à 06:13:40, Jean-Baptiste Kempf a écrit :
> > >> +                    __MAX( p_vids->p_bih->biSize - sizeof( VLC_BITMAPINFOHEADER ),
> > >> +                           p_vids->i_chunk_size - sizeof(VLC_BITMAPINFOHEADER) );
> > > not __MIN?
> > 
> > See 7f99f183c055dbb657a896adb568687b6264df44 from the same author.
> > 
> > https://trac.videolan.org/vlc/ticket/5952 has been reopened.
> > 
> > Should we revert the whole of his 2 commits ?
I cannot tell without further investigations but this smells like a
buffer over-read...

Regards,

-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre



More information about the vlc-devel mailing list