[vlc-devel] [PATCH 2/2] libvpx decoder

[Rafaël Carré]

Le 20/10/2013 17:11, Jean-Baptiste Kempf a écrit :
> On 20 Oct, Rafaël Carré wrote :

>> +vlc_module_begin ()
>> +    set_shortname("vpx")
>> +    set_description(N_("libvpx video decoder"))
> 
> Not really useful for users, if I may say. VP8/VP9 would be more
> interesting.

Unless the libvpx is not VP9 able :(

WebM decoder might be more suited.


>> +static int Open(vlc_object_t *p_this)
>> +{
>> +    decoder_t *dec = (decoder_t *)p_this;
>> +    const struct vpx_codec_iface *iface;
>> +    int vp;
> 
> I find this variable to verbose enough :)

verbose is not a verb, but I will rename it into vp_version :)

> Apart those minor things, LTGM. Nice.

Thanks

> Best regards,
>