[vlc-devel] [PATCH] omxil: use OMX chroma type instead of VLC type in GetVlcChromaSizes.

[Martin Storsjö]

On Wed, 23 Oct 2013, Felix Abecassis wrote:

> Using VLC type for lookup in chroma_format_table is not enough since
> there can be several corresponding OMX types with different
> dimensions.
> ---
> modules/codec/omxil/android_mediacodec.c | 2 +-
> modules/codec/omxil/omxil.c              | 8 ++++----
> modules/codec/omxil/omxil_utils.h        | 2 +-
> modules/codec/omxil/utils.c              | 8 +++-----
> 4 files changed, 9 insertions(+), 11 deletions(-)

The patch itself doesn't look bad (but you've got a stray change at the 
end of utils.c, but that can be fixed by whoever applies it, if it should 
be applied).

However, what I'm unsure of is which case this actually fixes. Is there 
any current config that is broken that is fixed by this patch?

The only place in chroma_format_table where one VLC chroma has got 
differing values depending on the OMX chroma format seems to be the values 
for VLC_CODEC_NV12, and the value for 
OMX_TI_COLOR_FormatYUV420PackedSemiPlanar might actually be wrong, since 
they should all have the same value for i_line_chroma_div.

So if the table is fixed, I'm not sure that the different formats actually 
can/should have different dimensions.

Despite that, the patch might still be useful, but first we need to know 
exactly what you are trying to fix here.

// Martin