[vlc-devel] [PATCH] Fix for crashes in several modules when running VLC on osx 10.6

[Rémi Denis-Courmont]

Le dimanche 27 octobre 2013 18:02:19 David Fuhrmann a écrit :
> Hi,
> 
> Since VLC 2.1, we noticed several crashes in different modules running on
> osx 10.6, if we compile the binary on osx 10.7 or later.

I don't know how the MacOS toolchain is designed.

But in general, the toolchain must be configured with the *oldest* supported OS 
version to provide binary compatiblity. At least, that is how it works on 
Windows (through _WIN32_WINNT) and on all ELF-based platforms (through custom 
build roots).

> As we have several
> features only working on 10.7 onwards, we need to compile the release
> binary on these newer versions. For 10.6, these features are deactivated.

Well, hmm, your "problems" very strongly suggest that you failed to deactivate 
those "features". I think you answered your own question.

> Any comments or suggestions are appreciated. :-)

This adds about 80kiB of dead binary (stripped) code *per* plugin on Windows 
or 1kiB on GNU/Linux. You do the maths with over 300 plugins.

-- 
Rémi Denis-Courmont
http://www.remlab.net/