[vlc-devel] [WIP/PATCH] avcodec: ensure correct buffer size

Ilkka Ollakka ileoo at videolan.org
Tue Oct 29 12:49:57 CET 2013


On Tue, Oct 29, 2013 at 12:56:26AM -0400, Tristan Matthews wrote:
> > Does the ulaw set p_sys->i_frame_size?

> This case is for libavcodec's pcm ulaw encoder ("mulaw"), which sets
> context->frame_size to 0.

> I believe the proper solution is probably to do some buffering of the
> input to ensure that avcodec_fill_audio_frame is always called with a
> buffer size that it likes. I will revise my patch and resend.

Input is buffered if codec tells context->frame_size to be != 0, but I
have understood that in case of context->frame_size == 0 there is no
matter which size frames are given to encoder.

But thanks for the patch, I'll check it later

-- 
Ilkka Ollakka
Ban the bomb.  Save the world for conventional warfare.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131029/5bb94c0c/attachment.sig>


More information about the vlc-devel mailing list