[vlc-devel] [PATCH] Core: Disable vout recycling for the visualization (fixes #9270) This avoids the vout opened for by the "visual" module to stay opened after having started an OpenGL based visualization.

[Rafaël Carré]

Hi,

Le 01/09/2013 13:48, Adrien Maglo a écrit :
> ---
>  src/audio_output/filters.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/audio_output/filters.c b/src/audio_output/filters.c
> index 796da1f..e20d275 100644
> --- a/src/audio_output/filters.c
> +++ b/src/audio_output/filters.c
> @@ -337,7 +337,9 @@ vout_thread_t *aout_filter_RequestVout (filter_t *filter, vout_thread_t *vout,
>       * to aout_request_vout_t inside filter_t (i.e. a level of indirection). */
>      const aout_request_vout_t *req = (void *)filter->p_owner;
>      char *visual = var_InheritString (filter->p_parent, "audio-visual");
> -    bool recycle = (visual != NULL) && strcasecmp(visual, "none");
> +    /* NOTE: Disable recycling to allways close the filter vout because OpenGL
> +     * visualizations do not use this function to ask for a context. */

Do they not do that because they explicitely request an opengl vout?

> +    bool recycle = false;
>      free (visual);
>  
>      return req->pf_request_vout (req->p_private, vout, fmt, recycle);
>