[vlc-devel] [PATCH 7/7] Preserve Ogg track total style when updating
Timothy B. Terriberry
tterribe at xiph.org
Mon Sep 2 21:07:03 CEST 2013
Jean-Baptiste Kempf wrote:
> I am against this change.
> We need to use the sane way of writing those, not perpetuate errors that
> other projects do.
I figured this would be the controversial one (which was why it was
last). I was operating under the principal of "don't break the user's
files" if they have some other software that reads things one way, and
not one of the others.
Really, we (Xiph) should have done a better job specifying this. We
don't really say anything about it anywhere except in a couple of
proposals that were never formally (or even informally) adopted.
In any case, the first hunk should perhaps still be applied to bring
parsing up to par with the demuxer's? I'm not really clear on why
ReadMeta exists both here and in the demuxer. But the one here does seem
to get called (twice!).
More information about the vlc-devel