[vlc-devel] [PATCH 5/7] Add support for parsing more Ogg tags

Jean-Baptiste Kempf jb at videolan.org
Tue Sep 3 00:09:54 CEST 2013

On 02 Sep, Timothy B. Terriberry wrote :
> I was sorting them in the same order they're listed in the header
> file, to make it easier to tell which ones are present and which
> ones are missing.

Fair enough, but this should have been in a different patch though...

> Personally I think it should be first value wins (which is what the
> taglib code does).

Why not.

> I think "show all values" is reasonable (it at
> least lets the user know the file is crazy), and was more consistent
> with the other code here.

Unfortunately, I disagree here.
The files having all of them are not crazy, the spec is crazy
(discussion are from 2003, and no decision was made????)

Having a muxer that adds the value to TRACKTOTAL, TOTALTRACKS and
WHATEVERTHELASTONEIS is an understandable idea, if you want all players
to display it.

It should merge them if they are of a similar value, because having 5,5
does not make sense, I think.

The reason there is a repetition in the end was because of

Best regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list